node_ip_addr parameter really should be host_public_ip_addr #307

detiber · 2014-10-07T15:18:42Z

the node_ip_addr parameter is used with register_dns (

puppet-openshift_origin/templates/register_dns.erb

    
           echo update add <%= scope.lookupvar('fqdn') %> 180 A <%= scope.lookupvar('::openshift_origin::node_ip_addr') %>

) to set the host dns entry.

Originally the variable was only used for setting the PUBLIC_IP in node.conf, hence the name, but it has a more generic use now.

This also highlights an issue with the usage of the variable in oo-install (https://github.com/openshift/openshift-extras/blob/4823853f7df32af6e1a2689826276e00e84e4d0a/oo-install/workflows/origin_deploy/originator.rb#L378) instead, originator.rb should be setting it to the value of host_instance.ip_addr for each host.

sdodson · 2014-11-12T21:33:22Z

@detiber What's our stance on backwards compatibility? Can we change this globally and expect people to just change when they notice catalog failures?

If not I think we'd have to do something like the following which I think is a bit of a hack
class openshift_origin (
...
node_ip_addr = $::ipaddr,
host_public_ip_addr = $node_ip_addr
... )

detiber · 2014-11-13T04:13:49Z

hmm, good point, I think we should possibly maintain backwards compatibility at least for a little bit... maybe add a deprecation warning to the puppet output to let users know (in addition to the comments/README)

sdodson added the enhancement label Nov 12, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

node_ip_addr parameter really should be host_public_ip_addr #307

node_ip_addr parameter really should be host_public_ip_addr #307

detiber commented Oct 7, 2014

sdodson commented Nov 12, 2014

detiber commented Nov 13, 2014

node_ip_addr parameter really should be host_public_ip_addr #307

node_ip_addr parameter really should be host_public_ip_addr #307

Comments

detiber commented Oct 7, 2014

sdodson commented Nov 12, 2014

detiber commented Nov 13, 2014