Skip to content

Conversation

@theComputeKid
Copy link
Member

@theComputeKid theComputeKid commented Nov 21, 2024

MacOS github runners are taking too much time. Reduced the configs as well as added more robust stale job kill policies.

@theComputeKid theComputeKid requested review from a team as code owners November 21, 2024 23:37
@github-actions github-actions bot added the devops Github automation label Nov 21, 2024
Copy link
Contributor

@dzarukin dzarukin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The thing is it's not only GCC 14.1 which spits false positive warnings.

I have an internal PR opened to suppress those warnings, should land tomorrow. Would you mind to wait for a day? Thanks.

@vpirogov
Copy link
Contributor

@theComputeKid, If this works please drop the build system changes and limit this PR to CI update.

@theComputeKid
Copy link
Member Author

@vpirogov @dzarukin okay, let me know when. Can you also upgrade MacOS GCC to 14 (as I did here) as part of your change to prove your suppression works?

@dzarukin
Copy link
Contributor

@vpirogov @dzarukin okay, let me know when. Can you also upgrade MacOS GCC to 14 (as I did here) as part of your change to prove your suppression works?

The change is on the main branch, you may rebase and validate MacOS through public PR system. Thank you.

@theComputeKid theComputeKid changed the title build: Turn off buggy gcc-14 compiler warning github: workflows: Reduce MacOS CI configs Nov 22, 2024
@theComputeKid
Copy link
Member Author

theComputeKid commented Nov 22, 2024

@vpirogov @dzarukin I've scoped the PR as suggested. But we still need:

-Wno-free-nonheap-object

My original change was:

# Compiler bug in gcc14 when optimizing memcpy: 
# https://github.com/oneapi-src/oneDNN/issues/2167
if (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 14.1)
    append(CMAKE_CCXX_FLAGS "-Wno-stringop-overflow -Wno-free-nonheap-object -Wno-array-bounds -Wno-restrict")
endif()

@vpirogov
Copy link
Contributor

make test
disable run_tests

@dzarukin
Copy link
Contributor

@vpirogov @dzarukin I've scoped the PR as suggested. But we still need:

-Wno-free-nonheap-object

My original change was:

# Compiler bug in gcc14 when optimizing memcpy: 
# https://github.com/oneapi-src/oneDNN/issues/2167
if (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 14.1)
    append(CMAKE_CCXX_FLAGS "-Wno-stringop-overflow -Wno-free-nonheap-object -Wno-array-bounds -Wno-restrict")
endif()

I opened an additional PR to work around this issue as well. I preferred to put a patch local to a function instead of to the whole build system.

@vpirogov vpirogov merged commit 1855808 into uxlfoundation:main Nov 27, 2024
13 of 23 checks passed
@vpirogov vpirogov added this to the v3.7 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops Github automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants