Skip to content

[cmake] fix condition for apple clang #2051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ilya-lavrenov wants to merge 2 commits into from
Closed

[cmake] fix condition for apple clang #2051

ilya-lavrenov wants to merge 2 commits into from

Conversation

@ilya-lavrenov
Copy link
Contributor

@ilya-lavrenov ilya-lavrenov commented Aug 22, 2024

Description

Cmake identifies Apple clang as "AppleClang"

Fixes # (github issue)

Checklist

General

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • Have you formatted the code using clang-format?

Performance improvements

  • Have you submitted performance data that demonstrates performance improvements?

New features

  • Have you published an RFC for the new feature?
  • Was the RFC approved?
  • Have you added relevant tests?

Bug fixes

  • Have you included information on how to reproduce the issue (either in a github issue or in this PR)?
  • Have you added relevant regression tests?

RFC PR

  • Does RFC document follow the template?
  • Have you added a link to the rendered document?

@ilya-lavrenov ilya-lavrenov requested a review from a team as a code owner August 22, 2024 07:46
@vpirogov
Copy link
Contributor

vpirogov commented Aug 23, 2024

@ilya-lavrenov, CI results indicate that this is not the case for configuration we are testing. Which CMake version did you try?

@ilya-lavrenov
Copy link
Contributor Author

ilya-lavrenov commented Aug 23, 2024

We use 3.13 as minimum required.
Do you really need to support cmake 2.8.x ?

@densamoilov
Copy link
Contributor

densamoilov commented Aug 23, 2024

Do you really need to support cmake 2.8.x ?

Good question, we may have to bump the minimum required CMake version to at least 3.5 as the older versions have been deprecated in CMake 3.27.

@vpirogov
Copy link
Contributor

vpirogov commented Aug 23, 2024

Good question, we may have to bump the minimum required CMake version to at least 3.5 as the older versions have been deprecated in CMake 3.27.

We are using CMake 2.8.12 as minimal supported version to ensure RHEL 7 compatibility. As RHEL 7 is now out of production support we could bump it. RHEL8 has 3.11.4 and Ubuntu 20.04 has 3.16.3.

spalicki
spalicki reviewed Oct 2, 2024
View reviewed changes
cmake/OpenMP.cmake
include("cmake/Threading.cmake")

if (APPLE AND CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
if (CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
Copy link
Contributor

@spalicki spalicki Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently this check applied to all Clangs on macOS, after the change only to Apple provided Clang. If we want to retain the old logic, then MATCHES would be a better option like: if (APPLE AND CMAKE_CXX_COMPILER_ID MATCHES "Clang"). It should catch both Clangs.

@spalicki spalicki mentioned this pull request Nov 26, 2024
Merged
@vpirogov
Copy link
Contributor

vpirogov commented Dec 9, 2024

Covered by #2225.

@vpirogov vpirogov closed this Dec 9, 2024
@ilya-lavrenov ilya-lavrenov deleted the patch-1 branch December 10, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spalicki spalicki spalicki left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ilya-lavrenov @vpirogov @densamoilov @spalicki