-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace old trackview icons #17924
feat: replace old trackview icons #17924
Conversation
@pollend I really like this change but it looks like it needs a merge from development to get it to build. Happy to run the build if you can update it |
Signed-off-by: Michael Pollind <[email protected]>
90d02b0
to
b0d5894
Compare
@lsemp3d I was hoping to get updated icons, from sig-ux. |
I think these are a good start |
Love this, thanks for looking into it :D Ideally, instead of adding these to a folder specific to the TrackView, you could give those icons more generic names and add them to the AzQtComponents Images folder: https://github.com/o3de/o3de/tree/development/Code/Framework/AzQtComponents/AzQtComponents/Images This way they can be re-used across different tools (A "Playback" folder would likely contain most of them). Of course there may be some icons that are very specific to the TrackView workflows, but the common ones should be reusable. On top of this, are the icons that were replaced still referenced somewhere? Deleting them if they are orphaned would be another small win :) |
@pollend should we hold off on merging to make these changes? |
I think I was just following what was already established. All the icons I think are duplicated but I think it makes sense to have like a standard set of icons for consistency. I also haven't looked at this in a long time so I don't remember which icons I changed. I think I borrowed icons from emotionfx and added my own using inkscape. |
I can merge and create a new issue with @AMZN-daimini 's suggestions |
What does this PR do?
I would like to replace the rest of the track view icons. these are a couple of the icons i could find from EmotionFX and a couple of tweaked ones.
How was this PR tested?
Please describe any testing performed.