Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shadows disappear after switching levels in Editor #18477

Open
Twolewis opened this issue Nov 15, 2024 · 1 comment
Open

Shadows disappear after switching levels in Editor #18477

Twolewis opened this issue Nov 15, 2024 · 1 comment
Labels
good-first-issue Issue ready for a new contributor according to the help wanted guidelines. kind/bug Categorizes issue or PR as related to a bug. sig/graphics-audio Categorizes an issue or PR as relevant to SIG graphics-audio.

Comments

@Twolewis
Copy link
Contributor

Describe the bug
In the Editor, if you switch levels the shadows will disappear. They will return if you switch to a different pipeline (or re-apply the current one), or create a new level from scratch.

Steps to reproduce
Steps to reproduce the behavior:

  1. Run the 2409.1 Editor
  2. Create two shaderball levels from the shaderball template level, LevelA and LevelB.
    • Note that upon level creation, shadows are visible.
  4. With either level open, switch to the other.
  5. ---> Shadows are no longer visible in the level that was switched to.

Expected behavior
Shadows shouldn't disappear on level switch.

Screenshots/Video
https://github.com/user-attachments/assets/6ab65ec8-1b1b-4360-a134-7610072466d3

Found in Branch
Tag: 2409.1
@Twolewis Twolewis added kind/bug Categorizes issue or PR as related to a bug. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 15, 2024
@jhanca-robotecai jhanca-robotecai added sig/graphics-audio Categorizes an issue or PR as relevant to SIG graphics-audio. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 21, 2024
@moudgils moudgils removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 11, 2024
@moudgils
Copy link
Contributor

moudgils commented Dec 11, 2024 •
edited
Loading

Sounds like a bug with re-initializing shadow parameters when switching levels.
Tips on how to debug - Feature processor in question is DirectionalLightFeatureProcessor. Recommend doing a gpu capture and confirm that we are in fact building the cascade shadow maps and binding them correctly ion the forward pass. If the cascade shadow maps are not getting built then debug the shadow map pass within DirectionalLightFeatureProcessor.

@moudgils moudgils added the good-first-issue Issue ready for a new contributor according to the help wanted guidelines. label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Issue ready for a new contributor according to the help wanted guidelines. kind/bug Categorizes issue or PR as related to a bug. sig/graphics-audio Categorizes an issue or PR as relevant to SIG graphics-audio.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Twolewis @moudgils @jhanca-robotecai