Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DirectXShaderCompiler to version 1.7.2308-o3de-rev2 #258

Merged
merged 8 commits into from
Jul 14, 2024

Conversation

akioCL
Copy link
Contributor

@akioCL akioCL commented Jun 28, 2024

-Add support for specialization constants

-Add support for specialization constants

Signed-off-by: Akio Gaule <[email protected]>
@akioCL akioCL requested review from moudgils and spham-amzn June 28, 2024 18:53
@amzn-changml
Copy link
Contributor

O3DE PR here: o3de/o3de#18080. We'll run AR on this and promote to production after this passes, then merge this PR, and finally the O3DE PR

@amzn-changml
Copy link
Contributor

amzn-changml commented Jul 14, 2024

This passed AR: https://jenkins.build.o3de.org/blue/organizations/jenkins/O3DE/detail/PR-18080/14/pipeline. @akioCL Feel free to merge this PR when ready, and I'll promote it to prod. Once that's done, merge the o3de PR: o3de/o3de#18080

@akioCL akioCL merged commit 0d329a0 into o3de:main Jul 14, 2024
9 of 11 checks passed
@akioCL akioCL deleted the update_dxc branch July 14, 2024 21:59
amzn-changml pushed a commit to amzn-changml/3p-package-source that referenced this pull request Aug 20, 2024
-Add support for specialization constants

Signed-off-by: Akio Gaule <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants