Skip to content

More accurate naming of config.completions.external settings #14351

Open
@NotTheDr01ds

Description

@NotTheDr01ds

Related problem

I'm working on grokking each of the configuration settings so that I can document them more fully.

Perhaps I'm misunderstanding this one, but it seems that the $env.config.completions.external settings are "oddly grouped" (at least for some of the subkeys).

  • external.enable: This has to do with completing external commands from the path. When disabled, no external commands on the path will be offered for completion in the "command position" (first token). This is in case there are performance issues with a slow search-path.
  • external.completer: This refers to a "non-built-in" completer function. It gets called for both external commands as well as internals. It is not limited to external commands only.
  • max_results: Again, this refers only to external commands from the path. It does not apply to argument completions.

To quote Sesame Street - "One of these things is not like the others. One of these things just doesn't belong." ;-)

Describe the solution you'd like

Rename:

  • From: $env.config.completions.external.completer
  • To: $env.config.completions.completion_command (alternative name suggestions welcome)

Describe alternatives you've considered

No response

Additional context and details

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    configurationIssue related to nu's configurationenhancementNew feature or requestnaming-things 🚲 🛖Working towards consistent naming. No bikeshedding brigade please!needs-triageAn issue that hasn't had any proper look

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions