-
Notifications
You must be signed in to change notification settings - Fork 3k
2.8.2 git shrinkwrap contains git+null #7961
Comments
That is definitely incorrect. It looks like |
wow, It looks like An actual valid URL would look like:
|
Ah, yup: https://github.com/npm/npm/blob/master/lib/cache/add-remote-git.js#L87 Should be sshurl() Which is then further mangled by: https://github.com/npm/npm/blob/master/lib/cache/add-remote-git.js#L415-L419 To result in the confusing bit above. |
Thanks for tracking that down, @iarna. For cloning purposes, npm needs |
Fixed in 387f889. Thanks for bringing this up! This will be part of the next patch release, going out very soon (like, less than an hour). |
...and indeed, this was included as part of |
For the record, just using |
With 2.8.2, we've run
npm install qubitdigital/ambassador --save && npm shrinkwrap
and the shrinkwrap was updated to:Notice the
git+null
- that looks like it's incorrect.The text was updated successfully, but these errors were encountered: