You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
Here are the apparently not-so-simple requirements:
GitHub shorthand syntax (org/repo) should be handled the same way by the CLI, regardless of whether it's passed in via the command line, or edited into package.json.
--save, --save-dev, and --save-optional should save GitHub dependencies as shorthand syntax, and not normalized to git+whatever: URLs, so that the symmetry of using them is preserved between the first and subsequent times you install them (shrinkwrapped GitHub dependencies should continue to resolve to git+x: URLs + resolved commit hashes).
Explicit Git URLs pointing to GitHub repos should preserve the protocol that was provided either on the command line or in package.json.
Explicit Git URLs pointing elsewhere should also be left alone, whether passed in on the command line, or via package.json.
We've made a few passes at this, which can be seen in #2556, #6978, #7121, #7486, #7630, #7766, and #7829. It's time to nail this down once and for all, and to get the right set of tests around it to prevent it from regressing in the future (although that is proving to be hard to do).
The text was updated successfully, but these errors were encountered:
Here are the apparently not-so-simple requirements:
org/repo
) should be handled the same way by the CLI, regardless of whether it's passed in via the command line, or edited intopackage.json
.--save
,--save-dev
, and--save-optional
should save GitHub dependencies as shorthand syntax, and not normalized togit+whatever:
URLs, so that the symmetry of using them is preserved between the first and subsequent times you install them (shrinkwrapped GitHub dependencies should continue to resolve togit+x:
URLs + resolved commit hashes).package.json
.package.json
.We've made a few passes at this, which can be seen in #2556, #6978, #7121, #7486, #7630, #7766, and #7829. It's time to nail this down once and for all, and to get the right set of tests around it to prevent it from regressing in the future (although that is proving to be hard to do).
The text was updated successfully, but these errors were encountered: