Skip to content

Windows GitHub Actions changes required #55929

Closed
@StefanStojanovic

Description

Version

No response

Platform

No response

Subsystem

No response

What steps will reproduce the bug?

Running vcbuild.bat

How often does it reproduce? Is there a required condition?

Always with VS 17.12.

What is the expected behavior? Why is that the expected behavior?

I expect Node.js to compile.

What do you see instead?

Compilation fails.

Additional information

I've already opened an issue to track this and reported it to Microsoft. In addition to that, I'll open a PR similar to #53863 marking the v17.12 as unsupported so people get informed.

In addition to everything already mentioned we should disable GitHub Actions for Windows: https://github.com/nodejs/node/actions/workflows/build-windows.yml, https://github.com/nodejs/node/actions/workflows/coverage-windows.yml and https://github.com/nodejs/node/actions/workflows/test-windows.yml as they will fail constantly (eg. #55270) because GitHub Runners use VS v17.12 now.

P.S. Maybe we can even remove test-windows.yml as it wasn't run recently?

cc @nodejs/platform-windows @nodejs/build

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions