Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.20.5 / next v20.x LTS version] NodeJS should provide some kind of warning when using import assertions as they are non-standard #55869

Open
alexsch01 opened this issue Nov 15, 2024 · 10 comments
Open

[v18.20.5 / next v20.x LTS version] NodeJS should provide some kind of warning when using import assertions as they are non-standard #55869

alexsch01 opened this issue Nov 15, 2024 · 10 comments
Labels
v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.

Comments

@alexsch01
Copy link
Contributor

alexsch01 commented Nov 15, 2024 •
edited by aduh95
Loading

Clarification

v18.20.4 (previous v18.x release) and v20.18.0 have a warning for both import assertions and import attributes

v18.20.5 removes this warning for both cases, I believe the import assertion warning should still be around

Seems to be caused by #55333

Version

v18.20.5

Platform

All

Subsystem

No response

What steps will reproduce the bug?

node --input-type=module -e 'import "data:application/json,{}" assert { type: "json" }'

How often does it reproduce? Is there a required condition?

Every time

What is the expected behavior? Why is that the expected behavior?

Regarding [What steps will reproduce the bug?]

It should provide some kind of warning since import assertions (not import attributes) are non-standard

Additional information

This also applies to the next v20.x LTS version
@alexsch01 alexsch01 changed the title [v18.20.5] NodeJS should provide some kind of warning when using import assertions as they are non-standard [v18.20.5 / future v20.x LTS version] NodeJS should provide some kind of warning when using import assertions as they are non-standard Nov 15, 2024
@alexsch01 alexsch01 changed the title [v18.20.5 / future v20.x LTS version] NodeJS should provide some kind of warning when using import assertions as they are non-standard [v18.20.5 / next v20.x LTS version] NodeJS should provide some kind of warning when using import assertions as they are non-standard Nov 15, 2024
@RedYetiDev
Copy link
Member

Adding a warning is a breaking change, and LTS lines are meant to be non-breaking.

@alexsch01
Copy link
Contributor Author

@RedYetiDev I should have clarified

v18.20.4 (previous v18.x release) and v20.18.0 have a warning for both import assertions and import attributes

v18.20.5 removes this warning for both cases, I believe the import assertion warning should still be around

@RedYetiDev RedYetiDev added the v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. label Nov 15, 2024
@RedYetiDev
Copy link
Member

RedYetiDev commented Nov 15, 2024 •
edited
Loading

Oh, okay. The removal / addition of a warning is typically semver major, I wonder why it was backported.

@alexsch01
Copy link
Contributor Author

This is probably the cause #55333

@RedYetiDev
Copy link
Member

Yes, likely.

@RedYetiDev RedYetiDev mentioned this issue Nov 15, 2024
Merged
@nicolo-ribaudo
Copy link
Contributor

This is a bit difficult to fix, because V8 doesn't tell us which syntax is being used. Does any of the maintainers have any suggestion?

@aduh95
Copy link
Contributor

aduh95 commented Nov 15, 2024

We need to reconsider #51631

@aduh95 aduh95 mentioned this issue Nov 15, 2024
Open
@RedYetiDev RedYetiDev added the v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. label Nov 15, 2024
@alexsch01
Copy link
Contributor Author

@aduh95 thanks for the PR, just letting you know that a v20.x version will be needed

@aduh95
Copy link
Contributor

aduh95 commented Nov 16, 2024

@alexsch01 I'm not sure why you ping me to repeat an information that's already in the OP. If you need a 20.x backport, make the PR yourself, or pay someone to do it for you (you can find support links in the README).

@alexsch01
Copy link
Contributor Author

my apologies

@RedYetiDev RedYetiDev removed the v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. label Nov 16, 2024
@aduh95 aduh95 added the v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexsch01 @nicolo-ribaudo @aduh95 @RedYetiDev