Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: missing data for URLSearchParams(urlSearchParams) constructor #55841

Open
skyclouds2001 opened this issue Nov 13, 2024 · 7 comments
Open

doc: missing data for URLSearchParams(urlSearchParams) constructor #55841

skyclouds2001 opened this issue Nov 13, 2024 · 7 comments
Labels
doc Issues and PRs related to the documentations.

Comments

@skyclouds2001
Copy link
Contributor

skyclouds2001 commented Nov 13, 2024 •
edited
Loading

Affected URL(s)

https://nodejs.org/docs/latest/api/url.html

Description of the problem

the history info of the two features doesn't mention these changes below

URLSearchParams constructor accepts a URLSearchParams object since v7.5.0, though this can be include as an iterable object (but the case is that the support for an iterable object only after v7.10.0)

URL.prototype.searchParams returns an empty list when being constructed before v7.5.0

see mdn/browser-compat-data#24998
see mdn/browser-compat-data#24997

also reference to #55840
@skyclouds2001 skyclouds2001 added the doc Issues and PRs related to the documentations. label Nov 13, 2024
@skyclouds2001 skyclouds2001 mentioned this issue Nov 13, 2024
Closed
@RedYetiDev
Copy link
Member

Hey, I see you opened this issue after the PR. There's no need to open the issue afterwards, tracking can be done in the PR, no?

@skyclouds2001
Copy link
Contributor Author

The content in the issue is not fixed by the PR.

I fired this issue because when I working on #55840, I met something not sure how to do, so I fire this issue intend for some disscussions or suggestions.

@skyclouds2001 skyclouds2001 changed the title doc: URLSearchParams constructor accepts a URLSearchParams object before v7.10.0 doc: missing data for URLSearchParams(urlSearchParams) constructor Nov 13, 2024
@RedYetiDev RedYetiDev reopened this Nov 13, 2024
@RedYetiDev
Copy link
Member

My bad! Apologies for the misunderstanding

1 similar comment
@RedYetiDev

This comment has been minimized.

Sign in to view
@skyclouds2001
Copy link
Contributor Author

My bad! Apologies for the misunderstanding

Never mind!

@aduh95
Copy link
Contributor

aduh95 commented Nov 14, 2024

Description of the problem

URLSearchParams constructor accepts a URLSearchParams object since v7.5.0, though this can be include as an iterable object (but the case is this is only supported after v7.10.0)

URL.prototype.searchParams returns an empty list when being constructed before v7.5.0

How is that a problem?

@skyclouds2001
Copy link
Contributor Author

How is that a problem?

I think the documentation need to represent these changes (and I've updated the issue's content)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aduh95 @RedYetiDev @skyclouds2001