-
-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add native border on floating window #2239
base: main
Are you sure you want to change the base?
Conversation
I have not reviewed the code yet, but I think this is a good feature. I'm just not sure about the configuration. It might be good enough for initial support, but I think we eventually should be able to configure this, and the shadows, which are similar, in the same way as native floating window borders. So, that it's window specific and can be applied to just the floating windows that need it. For that we need to discuss with the Neovim team on what's the best approach. Perhaps, a new setting guiborder, with some defaults. It would also be nice to render the current native borders, using our own renderer. The border propery as it is, is not enough, since it does not allow combining shadows with regular border styles. |
Yeh, we need some more information about these floating windows from Neovim. It's not easy to determine if the native border should be rendered or not now. This PR now adds a lot of borders on these floating windows. |
What kind of change does this PR introduce?
Did this PR introduce a breaking change?
A breaking change includes anything that breaks backwards compatibility either at compile or run time.
Draw a rectangle rounding floating windows. Also change color when entering that window.