Skip to content

ActiveGraph::Core::SchemaErrors::CypherError exceptions unused #1639

Open
@joshjordan

Description

@joshjordan

When we experience e.g. a constraint validation failure, we're getting Neo4j::Driver::Exceptions::ClientException instead of the expected error class, ActiveGraph::Core::SchemaErrors::ConstraintValidationFailedError.

Upon digging deeper, it appears to me that the ActiveGraph::Core::SchemaErrors::CypherError family of exceptions are completely unused. The API to convert from Neo4j driver errors to ActiveGraph errors is present, but never called. The specs only test the ActiveGraph::Core::SchemaErrors::CypherError API as far as I can see, but not that the conversion ever actually takes place.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions