fix: update to aegir 31 and others deps #141
Conversation
|
Thx for creating this PR. The latest update to multicodec breaks PeerId and a few other dependencies due to https://github.com/multiformats/js-cid/blob/master/package.json#L44 |
src/index.js
Outdated
| const multibase = require('multibase') | ||
| const multicodec = require('multicodec') | ||
| const { baseTable: codecs } = require('multicodec/src/base-table.js') | ||
| const { baseTable: codecs } = require('multicodec/src/generated-table') |
There was a problem hiding this comment.
We should stop using non-public APIs. We broke the world once, I don't want it to break it again.
If there is no code to name mapping in js-multicodec, we should add it properly to the public API. I can have a look later this week.
There was a problem hiding this comment.
Cids exports code to name?
There was a problem hiding this comment.
AFAICT it only changed the file name nothing else
src/index.js
Outdated
| const multibase = require('multibase') | ||
| const multicodec = require('multicodec') | ||
| const { baseTable: codecs } = require('multicodec/src/base-table.js') | ||
| const { nameToCode: codecs } = require('multicodec') |
There was a problem hiding this comment.
Having multicodec imported twice is a bit strange, but I guess we want to move fast.
vmx
left a comment
vmx
left a comment
There was a problem hiding this comment.
Yay, now the public API of js-multicodec is used!
No description provided.