This repository has been archived by the owner on Sep 3, 2021. It is now read-only.
This repository has been archived by the owner on Sep 3, 2021. It is now read-only.
Buffer instead of Uint8Array #126
Closed
Description
I lately upgrade js-cid from 0.8.3 to 1.0.0 who is a major upgarde as Uint8Array are used instead of Buffer.
However it appears that js-multibase do not always return Uint8Arrays.
I've a set of tests who crashed immediately when upgraded
ipfs cidv0 to ipfs cidv1 (base58btc, dag-pb) and vice versa
ipns cidv0 to ipns cidv1 (base58btc, dag-pb) to (base32, libp2p-key) and vice versa
ipns cidv1 to ipns cidv1 (base32, libp2p-key) to (base36, lip2p-key) and vice versa
According to :
https://github.com/multiformats/js-multibase/blob/master/src/constants.js
base58btc (dag-pb) who is used in IPFS cidv0 returns a Buffer
base36 (libp2p-key) who is used in IPNS cidv1 returns a Buffer
Thanks
Metadata
Assignees
Labels
No labels
Activity