[DashboardLayout] Fix app bar items alignment #4437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bharatkashyap
commented
Nov 18, 2024
bharatkashyap
commented
| Before | After |
|---|---|
 |
 |
bharatkashyap
added
design: ui
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
apedroferreira
requested changes
Nov 18, 2024
| flexWrap: 'wrap', | ||
| justifyContent: 'space-between', | ||
| width: '100%', | ||
| alignItems: 'center', |
There was a problem hiding this comment.
I don't remember exactly why I had added the padding but just retested and it should be fine to remove...
There was a problem hiding this comment.
Also for justifyContent and alignItems I guess we could just use the props of Stack directly, but it shouldn't be a big difference.
| @@ -14,7 +14,7 @@ import { ThemeSwitcher } from './ThemeSwitcher'; | |||
| */ | |||
| function ToolbarActions() { | |||
| return ( | |||
| <Stack direction="row"> | |||
| <Stack direction="row" alignItems="center"> | |||
There was a problem hiding this comment.
Besides this, can we also add this prop in the DashboardLayout line 377, in the Stack that wraps the actions and account slots?
(we actually have to so that they're aligned too)
pnpm-lock.yaml
Outdated
| @@ -4036,7 +4036,7 @@ packages: | |||
| engines: {node: '>=18'} | |||
| peerDependencies: | |||
| '@testing-library/dom': ^10.0.0 | |||
| '@types/react': ^18.3.11 | |||
| '@types/react': ^18.3.12 | |||
There was a problem hiding this comment.
There should be no changes here, right?
apedroferreira
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.