Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Separate example folders for Core and Studio #4301

Merged
merged 8 commits into from
Oct 30, 2024
Merged

[docs] Separate example folders for Core and Studio #4301

merged 8 commits into from
Oct 30, 2024

Conversation

bharatkashyap
Copy link
Member

Closes #4298

@bharatkashyap bharatkashyap added the docs Improvements or additions to the documentation label Oct 23, 2024
apedroferreira
apedroferreira approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@apedroferreira apedroferreira left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I gave it a quick check and maybe it's just missing updating the paths on the example READMEs?

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 29, 2024
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Oct 30, 2024
@bharatkashyap
Merge branch 'examples-separate' of github.com:bharatkashyap/mui-tool…
cbbe02e 
…pad; branch 'master' of github.com:mui/mui-toolpad into examples-separate
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 30, 2024
@bharatkashyap bharatkashyap merged commit 37bc672 into mui:master Oct 30, 2024
14 checks passed
@apedroferreira
Copy link
Member

The studio example deployments in Railway seem to be failing in the CI in master: https://github.com/mui/toolpad/commits/master/
I guess we need to update the paths somewhere else?

@bharatkashyap
Copy link
Member Author

The studio example deployments in Railway seem to be failing in the CI in master: https://github.com/mui/toolpad/commits/master/ I guess we need to update the paths somewhere else?

Yep, I noticed this as well (and flagged on Slack, I guess we can continue this there!) but couldn't investigate further without access to the Railway apps

@bharatkashyap bharatkashyap mentioned this pull request Nov 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apedroferreira apedroferreira apedroferreira approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[examples] Separate the examples in two directories (core & studio)
2 participants
@bharatkashyap @apedroferreira