[code-infra] Enable React compiler eslint plugin #4121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taking a look. |
| @@ -435,8 +436,9 @@ function DashboardLayout(props: DashboardLayoutProps) { | |||
|
|
|||
| // If useEffect was used, the reset would also happen on the client render after SSR which we don't need | |||
| React.useMemo(() => { | |||
| selectedItemIdRef.current = ''; | |||
| // eslint-disable-next-line react-hooks/exhaustive-deps | |||
| if (navigation) { | |||
There was a problem hiding this comment.
Having the selected item come from a context will eventually get rid of this so I guess this workaround should work for now.
There was a problem hiding this comment.
Have you seen that I added a bunch of helpers to optimize translating paths to navigation items and vice versa
https://github.com/mui/toolpad/blob/master/packages/toolpad-core/src/shared/navigation.tsx#L61-L166
it's being used by the new PageContainer breadcrumbs calculation. I expect a lot of it to be reusable for DashboardLayout. It adds some global caching to avoid recalculating these path => item maps over and over again.
There was a problem hiding this comment.
Nice, I'll try to use them!
apedroferreira
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@apedroferreira There is one error left:
Would you mind taking a look at it?