Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix landing page warnings #3830

Merged
merged 8 commits into from
Jul 23, 2024
Merged

[docs] Fix landing page warnings #3830

merged 8 commits into from
Jul 23, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jul 23, 2024 •
edited
Loading

Fix a bunch of warnings that appear on the core landingpage

  • Correct usage of Grid2
  • Fix slug => segment in Landing page demo
  • Fix hydration mismatches due to cssvars theme usage
  • Fix naming of components to improve DX (warnings were mentioning "CardGrid" for unrelated components)
  • Remove unused propTypes
  • Remove commented out code
  • Fix resolution issues around docs/... and @mui/docs/...
  • Fiz grid sizes in the features section. The right panel was sizing to the content and not constrained by the grid.

preview

Also see mui/material-ui#43042

@Janpot Janpot added the docs Improvements or additions to the documentation label Jul 23, 2024
@Janpot Janpot mentioned this pull request Jul 23, 2024
Merged
@Janpot Janpot marked this pull request as ready for review July 23, 2024 14:02
@Janpot Janpot requested a review from a team July 23, 2024 14:02
@Janpot Janpot enabled auto-merge (squash) July 23, 2024 16:51
@Janpot Janpot merged commit 09f9e72 into mui:master Jul 23, 2024
13 checks passed
@Janpot Janpot deleted the landing-page-warnings branch July 23, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apedroferreira apedroferreira apedroferreira approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Janpot @apedroferreira