@@ -11,9 +11,7 @@ Contents
1111Quick links
1212===========
1313
14- * issue tracker: https://launchpad.net/juju-core
15- * continuous integration: http://juju-ci.vapour.ws:8080/
16- * code review: http://reviews.vapour.ws/
14+ * issue tracker: https://launchpad.net/juju-
1715
1816Documentation:
1917* https://jujucharms.com/docs/
@@ -355,56 +353,29 @@ Code review
355353-----------
356354
357355The juju project uses peer review of pull requests prior to merging to
358- facilitate improvements both in code quality and in design. The code
359- review tool is ReviewBoard, hosted at http://reviews.vapour.ws/ . In the
360- event that the site is down, the project will temporarily fall back to
361- github for reviews of critical pull requests.
362-
363- A review request is automatically created for every pull request. A
364- link to that review request is added to the body of the pull request.
365- Whenever the pull request is updated, the review request is likewise
366- updated. Thus for the normal workflow of contribution, there should
367- be no need to worry about creating or updating review requests.
356+ facilitate improvements both in code quality and in design.
368357
369358Once you have created your pull request, it will be reviewed. Make sure
370359to address the feedback. Your request might go through several rounds
371- of feedback before the patch is approved or rejected. Once you get a
372- "ship it" from a member of the juju project, and there are not any
373- "NOT LGTM" comments in ReviewBoard or github, you are ready to have your
374- patch merged by a member of the juju team. Congratulations!
375-
376- The code review site uses github OAuth for authentication. To log in
377- simply go to login page and click the "github" button. The first time
378- you do this, it will redirect you to github to approve access and then
379- redirect you back. This first time is the only one where you will be
380- redirected to github. Furthermore, ReviewBoard will keep you logged in
381- between visits via session cookies.
382-
383- That first time you log in, a ReviewBoard account will be created for
384- you using your github username. However, your email address is not
385- added. If you want to receive review-related email, be sure to add your
386- email address to your ReviewBoard profile.
360+ of feedback before the patch is approved or rejected. Once you get an approval
361+ from a member of the juju project, you are ready to have your patch merged.
362+ Congratulations!
387363
388- For more information on ReviewBoard see:
389-
390- doc/contributions/reviewboard.md
391364
392365Continuous integration
393366----------------------
394367
395368Continuous integration is automated through Jenkins:
396369
397- http://juju-ci.vapour.ws:8080/
398-
399- The bot runs the test suite after ` $$merge$$ ` but before it actually
400- merges the pull request into develop.
370+ The bot runs on all commits during the PRE process,
371+ as well as handles merges. Use the ` $$merge$$ ` comment to land PR's.
401372
402373Community
403374=========
404375
405376The juju community is growing and you have a number of options for
406377interacting beyond the workflow and the
407- [ issue tracker] ( https://launchpad.net/juju-core ) .
378+ [ issue tracker] ( https://launchpad.net/juju ) .
408379
409380Take a look at the community page:
410381
0 commit comments