Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock / Unlock does not work anymore #102

Closed
McFarTech opened this issue Dec 8, 2023 · 18 comments
Closed

Lock / Unlock does not work anymore #102

McFarTech opened this issue Dec 8, 2023 · 18 comments
Labels
bug Something isn't working

Comments

@McFarTech
Copy link

McFarTech commented Dec 8, 2023 •
edited
Loading

Hi.

My Lock / Unlock does not seem to work using the intergration but is fine using the JLR Remote app

I have everything set from what i can see. Any suggestions?

homeassistant.exceptions.InvalidStateError: Invalid state with length 285. State max length is 255 characters.
2023-12-08 15:14:39.081 ERROR (MainThread) [custom_components.jlrincontrol.services] Error calling service unlock on vehicle McFarlane Disco Sport. Error is
2023-12-08 15:15:03.410 ERROR (MainThread) [custom_components.jlrincontrol.services] Error calling service unlock on vehicle McFarlane Disco Sport. Error is
2023-12-08 15:15:41.179 DEBUG (MainThread) [custom_components.jlrincontrol.lock] Unlocking vehicle
2023-12-08 15:15:42.246 ERROR (MainThread) [custom_components.jlrincontrol.services] Error calling service unlock on vehicle McFarlane Disco Sport. Error is
2023-12-08 15:15:42.776 DEBUG (MainThread) [custom_components.jlrincontrol] Received status data update for McFarlane Disco Sport
2023-12-08 15:15:43.141 DEBUG (MainThread) [custom_components.jlrincontrol] Received position data update for McFarlane Disco Sport
2023-12-08 15:15:43.142 DEBUG (MainThread) [custom_components.jlrincontrol] Privacy mode is enabled. Trip data will not be loaded for McFarlane Disco Sport
2023-12-08 15:15:43.142 INFO (MainThread) [custom_components.jlrincontrol] JLR InControl update received for McFarlane Disco Sport
2023-12-08 15:15:43.142 DEBUG (MainThread) [custom_components.jlrincontrol.entity] Updating McFarlane Disco Sport Info
2023-12-08 15:15:43.143 DEBUG (MainThread) [custom_components.jlrincontrol.entity] Updating McFarlane Disco Sport Windows
2023-12-08 15:15:43.143 DEBUG (MainThread) [custom_components.jlrincontrol.entity] Updating McFarlane Disco Sport Alarm
2023-12-08 15:15:43.143 DEBUG (MainThread) [custom_components.jlrincontrol.entity] Updating McFarlane Disco Sport Tyres
2023-12-08 15:15:43.144 DEBUG (MainThread) [custom_components.jlrincontrol.entity] Updating McFarlane Disco Sport Service Info
2023-12-08 15:15:43.144 DEBUG (MainThread) [custom_components.jlrincontrol.entity] Updating McFarlane Disco Sport Range
2023-12-08 15:15:43.144 DEBUG (MainThread) [custom_components.jlrincontrol.entity] Updating McFarlane Disco Sport Status
2023-12-08 15:15:43.144 DEBUG (MainThread) [custom_components.jlrincontrol.entity] Updating McFarlane Disco Sport All Info
2023-12-08 15:15:43.146 DEBUG (MainThread) [custom_components.jlrincontrol.entity] Updating McFarlane Disco Sport Doors
2023-12-08 15:15:43.146 DEBUG (MainThread) [custom_components.jlrincontrol.device_tracker] Updating McFarlane Disco Sport Device Tracker
@hawkseye76
Copy link

Same here. Nothing seems to have been working for a few days now.

@msp1974
Copy link
Owner

msp1974 commented Dec 8, 2023

Have you upgraded to HA 2023.12? This broke another integration I write? Will have a look over weekend to see if mine has also stopped working. I have upgraded to 2023.12.

@McFarTech
Copy link
Author

Hi , Yes i am running 2023.12.0

@hawkseye76
Copy link

I'm still on 2023.11.3

@OGB1952
Copy link

OGB1952 commented Dec 9, 2023 •
edited
Loading

I'm on HA 2023.12 and have also lost lock/unlock for some reason. It was working OK up until a week or so ago, I'm afraid I can't say for sure when it stopped working as I only noticed the integration was showing my doors as being unlocked a few days ago, then discovered that lock/unlock wasn't working via HA (but is fine with the InControl app).

@McFarTech
Copy link
Author

Glad its not just me, Hopefully will get sorted.

@hawkseye76
Copy link

looks like they changed the commands for lock and unlock. the python api this is based on is broken as well.

@msp1974
Copy link
Owner

msp1974 commented Dec 11, 2023

Ok, had some time to look at this today and will issue a PR to @ardevd to fix the api. Once he has been able to release this, I will issue an update which will resolve.

@ardevd
Copy link

ardevd commented Dec 11, 2023

Thank you very much for the contribution! Will merge and update asap!

@McFarTech
Copy link
Author

Thank you so much guys for taking care of this issue.

@msp1974
Copy link
Owner

msp1974 commented Dec 11, 2023

v2.2.4 released which fixes the issue. Thanks @ardevd for the quick merge of PR and new release.

@McFarTech
Copy link
Author

Thank you. All working again now.

@hawkseye76
Copy link

Same here. All is working as expected after update. Thanks for the quick response!

@dblanc42
Copy link

Thanks for the update. Just being curious, do you know what changed? Would it affect pre-conditioning and/or charging?

@msp1974
Copy link
Owner

msp1974 commented Dec 13, 2023

It was the content type header in the request was set at v2 and needed to be v3. It is possible that the same applies to other requests. You will see an error in the logs however if this is the case. What issue are you having?

@dblanc42
Copy link

dblanc42 commented Dec 17, 2023 •
edited
Loading

Thanks for the quick reply, had missed it...
It was more curiosity than anything else. I don't use lock/unlock much, but was wondering if the preconditioning might be broken maybe in the future, if the same applied

@OGB1952
Copy link

OGB1952 commented Dec 17, 2023

Many thanks for sorting this, much appreciated. I can confirm that preconditioning was also broken, as well as door locking, but is now working fine.

@ismarslomic
Copy link
Collaborator

Closing this issue as it has been resolved! Thanks for reporting the bug and helping out on testing!

@ismarslomic ismarslomic added the bug Something isn't working label Dec 17, 2023
@ismarslomic ismarslomic changed the title Lock Unlock Lock / Unlock does not work anymore Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@ardevd @ismarslomic @hawkseye76 @msp1974 @McFarTech @OGB1952 @dblanc42