fix(ui): Scroll restoration #1833
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeinerfonseca
changed the title
There was a problem hiding this comment.
I really like how you implemented the scroll restoration in such a way that it can easily be reused by basically any component. Thank you!
I'll play around with this locally here soon, but i want to get this merged since it'll simplify a lot of stuff!
I'll take a deeper look into the code then, and merge/comment from there!
| return context; | ||
| } | ||
|
|
||
| export function ScrollPositionProvider({ |
There was a problem hiding this comment.
This entire thing is fantastic, I need to play around with it for a bit. But I really love this implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a reusable hook to restore positioning in any route with an scrollable element.
The scroll positioning will be restored regardless of the navigation type.
An enhancement could be implemented for the following scenario:
Say we have route
foo/bar, if it accessed through a POP navigation type, then scroll is restoredto the last positioning. Otherwise, if navigation type is PUSH, then scroll is restored to zero (top).
Let me know your thoughts.