* ext/psych/lib/psych/visitors/yaml_tree.rb: fix NameError dumping and

tenderlove · tenderlove · commit 86b2f938f5c4 · 2014-08-29T21:41:02.000Z
loading. Fixes GH ruby#85. Thanks @brentdax for the patch! * test/psych/test_exception.rb: test for fix git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47319 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
diff --git a/ChangeLog b/ChangeLog
@@ -1,3 +1,9 @@
+Sat Aug 30 06:39:48 2014  Aaron Patterson <aaron@tenderlovemaking.com>
+
+	* ext/psych/lib/psych/visitors/yaml_tree.rb: fix NameError dumping and
+	  loading. Fixes GH #85. Thanks @brentdax for the patch!
+	* test/psych/test_exception.rb: test for fix
+
 Sat Aug 30 06:23:40 2014  Aaron Patterson <aaron@tenderlovemaking.com>
 
 	* ext/psych/lib/psych/scalar_scanner.rb: fix loading strings that
diff --git a/ext/psych/lib/psych/visitors/yaml_tree.rb b/ext/psych/lib/psych/visitors/yaml_tree.rb
@@ -211,6 +211,25 @@ def visit_Exception o
         @emitter.end_mapping
       end
 
+      def visit_NameError o
+        tag = ['!ruby/exception', o.class.name].join ':'
+
+        @emitter.start_mapping nil, tag, false, Nodes::Mapping::BLOCK
+
+        {
+          'message'   => o.message.to_s,
+          'backtrace' => private_iv_get(o, 'backtrace'),
+        }.each do |k,v|
+          next unless v
+          @emitter.scalar k, nil, nil, true, false, Nodes::Scalar::ANY
+          accept v
+        end
+
+        dump_ivars o
+
+        @emitter.end_mapping
+      end
+
       def visit_Regexp o
         register o, @emitter.scalar(o.inspect, nil, '!ruby/regexp', false, false, Nodes::Scalar::ANY)
       end
diff --git a/test/psych/test_exception.rb b/test/psych/test_exception.rb
@@ -16,6 +16,12 @@ def setup
       @wups = Wups.new
     end
 
+    def test_naming_exception
+      err     = String.xxx rescue $!
+      new_err = Psych.load(Psych.dump(err))
+      assert_equal err.message, new_err.message
+    end
+
     def test_load_takes_file
       ex = assert_raises(Psych::SyntaxError) do
         Psych.load '--- `'

-Original file line number
+Diff line change
@@ @@ -1,3 +1,9 @@ @@
 +Sat Aug 30 06:39:48 2014  Aaron Patterson <[email protected]>
++
 +	* ext/psych/lib/psych/visitors/yaml_tree.rb: fix NameError dumping and
 +	  loading. Fixes GH #85. Thanks @brentdax for the patch!
 +	* test/psych/test_exception.rb: test for fix
++
 Sat Aug 30 06:23:40 2014  Aaron Patterson <[email protected]>
 	* ext/psych/lib/psych/scalar_scanner.rb: fix loading strings that