Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When decoding Time with empty string, toggle IsSet #55

Closed
rtgibbons opened this issue Sep 17, 2019 · 1 comment
Closed

When decoding Time with empty string, toggle IsSet #55

rtgibbons opened this issue Sep 17, 2019 · 1 comment

Comments

@rtgibbons
Copy link

rtgibbons commented Sep 17, 2019

cli/ext/decoders.go

Lines 51 to 55 in 205c0b8

now := time.Now()
if s == "" {
t.Time = now
return nil
}

I think it makes sense to toggle IsSet to true here?

@suntong
Copy link
Collaborator

suntong commented Jan 15, 2021

close via 238c6b9

@suntong suntong closed this as completed Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants