Skip to content

Commit c54c262

Browse files
committed
Ryan! STAHP! Stop trying to "optimize" this.
[git-p4: depot-paths = "//src/minitest/dev/": change = 14592]
1 parent 690d38a commit c54c262

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

lib/minitest.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -411,6 +411,7 @@ def self.run reporter, options = {}
411411
pos = Regexp.new $1 if pos.kind_of?(String) && pos =~ %r%/(.*)/%
412412
neg = Regexp.new $1 if neg.kind_of?(String) && neg =~ %r%/(.*)/%
413413

414+
# at most 1-2% slower than a 1-pass version, stop optimizing this
414415
filtered_methods = self.runnable_methods
415416
.select { |m| !pos || pos === m || pos === "#{self}##{m}" }
416417
.reject { |m| neg && (neg === m || neg === "#{self}##{m}") }

0 commit comments

Comments
 (0)