Skip to content

DSCv3 user settings file enhancements #5425

@AmelBawa-msft

Description

@AmelBawa-msft

Comment 1:

I would definitely suggest having the UserSettings code handle the reading/writing of settings file itself. This code doesn't consider the settings backup file; which might be relevant to consider.

The question RE: the backup file becomes, "What are we managing with this resource?". Is it the contents of the primary settings file or is it the logical settings that WinGet will use when run?

Should we refuse to operate if the operation requires reading JSON from the settings file and that file is corrupt?

Comment 2:

Not having a settings file is a legitimate state (in fact, the most likely state on a new system).

Add a test(s) that ensures proper handling when the settings file does not exist.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Issue-FeatureThis is a feature request for the Windows Package Manager client.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions