Extensions SecretStorage issue: Input is not valid base64-encoded data. #147515
Description
Does this issue occur when all extensions are disabled?: No
- VS Code Version: 1.66.1, 1.66.2
- OS Version: Ubuntu 20.04.4
So the issue I'm having is as an extension developer (ckolkman.vscode-postgres).
I've had users report an issue that I have tracked back down to vscode - I can confirm the issue on the above versions, but don't know the full extent on other os versions. (Borvik/vscode-postgres#196)
The error being received is: "Input is not valid base64-encoded data."
I've tracked this down to getting the secret from secret storage (https://code.visualstudio.com/api/references/vscode-api#SecretStorage).
I use the SecretStorage api to securely store credentials used by my extension. The api docs don't seem to indicate a change - but something appears to have changed (whether by design and the docs need to change, or by introducing a bug).
The issue does not appear to affect vscode 1.66.0 - reverting to that version allows it to work.
I do not know whether it affects whether it affects storing
secrets - but can confirm on getting
secrets.
Steps to Reproduce (with referenced extension - so far):
- In vscode 1.66.0 - with extension, create a db connection with pwd to store creds (without pwd won't use store creds so it won't use the SecretStorage)
- Upgrade vscode
- Try to view the connection explorer and it will error when attempting to pull the secret from storage.
Activity