-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added -s, --stand-alone-instance #174
Conversation
ping: @rdswift, since you were interested. |
One other thing... Would you mind adding yourself to the |
@skelly37: I submitted PR https://github.com/skelly37/picard-docs/pull/1 against your branch to add a new page that generally explains the way that Picard starts up. That way all the related changes will appear together on the same PR when merging into the master documentation branch. |
Add section on starting Picard
Excellent, thanks! |
Should we include a warning about the pipe error we’re leaving unsolved for now? i.e. unexitable Picard after removing the pipe file manually on Unix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions, most of which are subjective so I won't be offended if they are ignored!
Co-authored-by: Adam James <[email protected]>
Co-authored-by: Adam James <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is actually my hope that this issue is addressed before the Picard 3.0 release so that this note / warning is not required.
Co-authored-by: Bob Swift <[email protected]>
I think we need an additional appendix documenting the new Basically it's:
|
Depending on what other actions will be able to be initiated from the command line, it likely requires a separate section on "Using Picard from the Command Line" or "Batch Processing with Picard". I'm not sure an appendix is the right place for this. I'm thinking more as a new page under the "Using Picard" section. |
|
||
the file or files to load | ||
the file(s), URL(s) and MBID(s) to load |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we include a brief description of the formats of the inputs? Most people will probably understand the files and URLs, but not the required format for MBIDs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed
Co-authored-by: Bob Swift <[email protected]>
Co-authored-by: Bob Swift <[email protected]>
I'll leave a TODO list later to sum up what still has to be done |
TODO:
@rdswift I can write most (if not all) of it but I'm bad at .rst. My idea is that I will send you my notes in markdown, e.g. via e-mail, and you will (kindly please :) ) help me with proper formatting |
That's fine with me. I appreciate whatever you can provide in terms of description of the new functionality. Thanks. |
Positional arguments documentation:In Picard one can pass 3 types of positional arguments:
|
Remote commandsGeneral
Usage
List of available commands
|
Note that this has been changed in metabrainz/picard#2167 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skelly37 this will need to be updated to include the changes being made in metabrainz/picard#2173 which I can do (as well as including the RST changes for the other text you provided), but I think that you will need to remove the DRAFT designation on this PR and allow changes by maintainers.
Alternatively, if you want me to take over and complete all the remaining changes, I can clone your work so far, make the changes and additions, and then submit a new PR based on the updated clone. We can then close this PR.
In either case, I still want to make sure that you're credited for your contributions in the documentation. Thanks.
@rdswift Apologies for the response delay. I’d suggest to go with the second option, as you’d have full control over the branch. Let me know when to close this PR, thanks in advance. |
This PR has been combined into #178 |
Summary
This is a…
Reason for the Change
metabrainz/picard#2116 will introduce new flag
Description of the Change
Added the new flag
Additional Action Required
Nope.