Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added -s, --stand-alone-instance #174

Closed
wants to merge 20 commits into from
Closed

added -s, --stand-alone-instance #174

wants to merge 20 commits into from

Conversation

skelly37
Copy link
Contributor

Summary

This is a…

  • Correction
  • Addition
  • Restructuring
  • Minor / simple change (like a typo)
  • Other

Reason for the Change

metabrainz/picard#2116 will introduce new flag

Description of the Change

Added the new flag

Additional Action Required

Nope.

@skelly37
Copy link
Contributor Author

ping: @rdswift, since you were interested.

@rdswift rdswift added documentation Improvements or additions to documentation do not merge Do not merge until requirements are met labels Jun 27, 2022
@rdswift rdswift added this to the 3.0 milestone Jun 27, 2022
@rdswift
Copy link
Collaborator

rdswift commented Jun 28, 2022

One other thing... Would you mind adding yourself to the about_picard/acknowledgements.rst file? Thanks.

@rdswift
Copy link
Collaborator

rdswift commented Jul 7, 2022

@skelly37: I submitted PR https://github.com/skelly37/picard-docs/pull/1 against your branch to add a new page that generally explains the way that Picard starts up. That way all the related changes will appear together on the same PR when merging into the master documentation branch.

Add section on starting Picard
@skelly37
Copy link
Contributor Author

skelly37 commented Jul 7, 2022

Excellent, thanks!

@skelly37
Copy link
Contributor Author

skelly37 commented Jul 9, 2022

Should we include a warning about the pipe error we’re leaving unsolved for now? i.e. unexitable Picard after removing the pipe file manually on Unix.

Copy link

@atj atj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions, most of which are subjective so I won't be offended if they are ignored!

getting_started/starting.rst Show resolved Hide resolved
appendices/command_line.rst Outdated Show resolved Hide resolved
getting_started/starting.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@rdswift rdswift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is actually my hope that this issue is addressed before the Picard 3.0 release so that this note / warning is not required.

getting_started/starting.rst Show resolved Hide resolved
getting_started/starting.rst Outdated Show resolved Hide resolved
getting_started/starting.rst Outdated Show resolved Hide resolved
@skelly37
Copy link
Contributor Author

I think we need an additional appendix documenting the new mbid://.

Basically it's:

mbid://<entity-type>/<mbid>

@rdswift
Copy link
Collaborator

rdswift commented Jul 21, 2022

I think we need an additional appendix documenting the new mbid://.

Depending on what other actions will be able to be initiated from the command line, it likely requires a separate section on "Using Picard from the Command Line" or "Batch Processing with Picard". I'm not sure an appendix is the right place for this. I'm thinking more as a new page under the "Using Picard" section.


the file or files to load
the file(s), URL(s) and MBID(s) to load
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include a brief description of the formats of the inputs? Most people will probably understand the files and URLs, but not the required format for MBIDs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

getting_started/starting.rst Outdated Show resolved Hide resolved
getting_started/starting.rst Outdated Show resolved Hide resolved
@skelly37
Copy link
Contributor Author

skelly37 commented Sep 4, 2022

I'll leave a TODO list later to sum up what still has to be done

@skelly37
Copy link
Contributor Author

skelly37 commented Sep 4, 2022

TODO:

  • allowed URIs (positional arguments)
  • list of commands
  • re-read the diff to see if it is still up to date

@rdswift I can write most (if not all) of it but I'm bad at .rst. My idea is that I will send you my notes in markdown, e.g. via e-mail, and you will (kindly please :) ) help me with proper formatting

@rdswift
Copy link
Collaborator

rdswift commented Sep 4, 2022

@rdswift I can write most (if not all) of it but I'm bad at .rst. My idea is that I will send you my notes in markdown, e.g. via e-mail, and you will (kindly please :) ) help me with proper formatting

That's fine with me. I appreciate whatever you can provide in terms of description of the new functionality. Thanks.

@skelly37
Copy link
Contributor Author

skelly37 commented Sep 6, 2022

Positional arguments documentation:

In Picard one can pass 3 types of positional arguments:

  • file:
    • relative path: will be auto-converted to an absolute path, where the current working directory is this path's parent
    • absolute path
    • file:// URI
  • supported URL (the same ones that work for drag'n'drop in GUI mode)
    • http:// URI
    • https:// URI
  • MBID URI
    • mbid://<entity-type>/<mbid>
    • Examples:
      • mbid://release/dbd0ce67-cae6-33eb-8f5a-1143a30c2353
      • mbid://artist/83d91898-7763-47d7-b03b-b92132375c47

@skelly37
Copy link
Contributor Author

skelly37 commented Sep 6, 2022

Remote commands

General

  • Picard remote process handling consists of 2 steps:
    1. It tries to pass commands to execute to an existing instance,
    2. If the commands were not received, it starts a new app that will process the command pipeline.
  • Commands are case-insensitive.
  • Commands are processed in the order they were provided.

Usage

picard -e <command> <arg(s)>

List of available commands

  • CLEAR_LOGS
    Clear the Picard logs.

  • CLUSTER
    Cluster all files in the cluster pane.

  • FINGERPRINT
    Calculate acoustic fingerprints for all (matched) files in the album pane.

  • FROM_FILE <absolute path>
    Load command pipeline from the provided absolute path.

    • #-prefixed comments are accepted.
    • 1 line per 1 command, a single line should contain as much as single picard -e <command> <argstring> call.
  • LOAD <MBID/URL/absolute path(s)>
    Load one or more provided arguments to Picard.

    • Basically an equivalent of the positional arguments but it can be placed:
      • anywhere in the picard call,
      • in the command pipeline files.
    • NOTE: LOAD does not support passing remote commands.
  • LOOKUP
    Lookup all clusters in the cluster pane.

  • LOOKUP_CD <device/log file>
    Read CD from the selected drive and lookup on MusicBrainz.
    Without argument, it defaults to the first (alphabetically) available disc drive.

  • QUIT
    Exit the running instance of Picard.

  • REMOVE <absolute path to 1 or more files>
    Remove the file from Picard. Do nothing if no arguments provided.

  • REMOVE_ALL
    Remove all files form Picard.

  • REMOVE_EMPTY
    Remove all empty clusters and albums.

  • REMOVE_SAVED
    Remove all saved releases from the album pane.

  • REMOVE_UNCLUSTERED
    Remove all unclustered files from the cluster pane.

  • SAVE_MATCHHED
    Save all matched releases from the album pane.

  • SAVE_MODIFIED
    Save all modified files from the album pane.

  • SCAN
    Scan all files in the cluster pane.

  • SHOW
    Make the running Picard instance the currently active window.

  • SUBMIT_FINGERPRINTS
    Submit outstanding acoustic fingerprints for all (matched) files in the album pane.

  • WRITE_LOGS <path>
    Save logs with the current verbosity level to the file passed as an argument.

@rdswift
Copy link
Collaborator

rdswift commented Nov 6, 2022

  • LOOKUP
    Lookup all clusters in the cluster pane.

Note that this has been changed in metabrainz/picard#2167

Copy link
Collaborator

@rdswift rdswift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skelly37 this will need to be updated to include the changes being made in metabrainz/picard#2173 which I can do (as well as including the RST changes for the other text you provided), but I think that you will need to remove the DRAFT designation on this PR and allow changes by maintainers.

Alternatively, if you want me to take over and complete all the remaining changes, I can clone your work so far, make the changes and additions, and then submit a new PR based on the updated clone. We can then close this PR.

In either case, I still want to make sure that you're credited for your contributions in the documentation. Thanks.

@skelly37
Copy link
Contributor Author

skelly37 commented Dec 2, 2022

@rdswift Apologies for the response delay. I’d suggest to go with the second option, as you’d have full control over the branch. Let me know when to close this PR, thanks in advance.

@rdswift
Copy link
Collaborator

rdswift commented Dec 3, 2022

This PR has been combined into #178

@rdswift rdswift closed this Dec 3, 2022
@skelly37 skelly37 deleted the single-instance branch December 5, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Do not merge until requirements are met documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants