fix: relative url 2 full url use error base url#584
Merged
mogery merged 1 commit intofirecrawl:mainfrom Feb 13, 2025
Merged
Conversation
according to ： https://developer.mozilla.org/en-US/docs/Web/API/URL/URL the second parameter: A string representing the base URL to use in cases where url is a relative reference so need use the pageUrl , not url origin eg: when pageUrl = http://example.com/a/b/c/d.html and tag a href is '../e.html' then correct: new URL('../e.html','http://example.com/a/b/c/d.html') incorrect: new URL('../e.html','http://example.com')
Member
|
Good catch! Thank you! |
mogery
approved these changes
Sep 1, 2024
|
@mogery Could you please clarify the reason for the delay in merging this pull request? |
Member
|
My bad. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
according to ： https://developer.mozilla.org/en-US/docs/Web/API/URL/URL
eg:
http://example.com/a/b/c/d.html<a herf="../e.html"></a>correct:
new URL('../e.html','http://example.com/a/b/c/d.html')incorrect:
new URL('../e.html','http://example.com')