Add waitFor of 5000ms for changeTracking format#1450
Merged
nickscamara merged 4 commits intomainfrom Apr 13, 2025
Merged
Conversation
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
mogery
requested changes
Apr 13, 2025
Comment on lines
+393
to
+395
| if (options.formats.includes("changeTracking") && options.waitFor < 5000) { | ||
| options.waitFor = 5000; | ||
| } |
Member
There was a problem hiding this comment.
This shouldn't be in this file. Put it in v1 types in the refine layer, where the extract/json logic is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a minimum waitFor of 5000ms for all requests that have the changeTracking format to ensure proper change detection. Link to Devin run: https://app.devin.ai/sessions/d0133257eba54d00b3a3589e85399215