Skip to content

feat(log_job): start saving jobs to GCS#1424

Merged
mogery merged 1 commit intomainfrom
mog/upload-to-s3
Apr 8, 2025
Merged

feat(log_job): start saving jobs to GCS#1424
mogery merged 1 commit intomainfrom
mog/upload-to-s3

Conversation

@mogery
Copy link
Member

@mogery mogery commented Apr 8, 2025

Error-resistant so we might as well just start putting jobs in to stress test it

@mogery mogery requested a review from Copilot April 8, 2025 17:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • apps/api/package.json: Language not supported
Comments suppressed due to low confidence (1)

apps/api/src/services/logging/log_job.ts:4

  • There is a duplicate dotenv initialization; since configDotenv() is explicitly called later, consider removing the import of "dotenv/config" to prevent potential side effects.
import "dotenv/config";

@mogery mogery merged commit bd1c1b0 into main Apr 8, 2025
2 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants