fix(js-sdk): isows import issues (FIR-1586) (FIR-1536)#1411
Merged
Conversation
Member
Author
|
still needs manual testing |
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- apps/js-sdk/firecrawl/package.json: Language not supported
Comments suppressed due to low confidence (2)
apps/js-sdk/firecrawl/src/index.ts:1883
- WebSocket initialization is now handled asynchronously which may lead to race conditions if instance methods attempt to use 'ws' before it is set. Consider ensuring the WebSocket is fully initialized before any dependent calls.
(async () => {
apps/js-sdk/firecrawl/src/index.ts:1886
- The updated WebSocket URL now appends '/watch'. Please confirm that this change is consistent with the intended API design.
this.ws = new isows.WebSocket(`${app.apiUrl.replace("http", "ws")}/v1/crawl/${id}/watch`);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.