feat(scrapeURL): return js returns from f-e (FIR-1535)#1385
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality for returning JavaScript execution results from the front-end scraping engine.
- Adds a new javascriptReturns field to the EngineScrapeResult type and related types.
- Filters and processes JavaScript execution results in the fire-engine scraper and updates schema validation in checkStatus.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/api/src/scraper/scrapeURL/engines/index.ts | Added javascriptReturns field to the EngineScrapeResult type |
| apps/api/src/scraper/scrapeURL/engines/fire-engine/index.ts | Processed and mapped javascriptReturns from response action results |
| apps/api/src/scraper/scrapeURL/engines/fire-engine/checkStatus.ts | Extended schema validation to include executeJavascript results and updated error checks |
| apps/api/src/controllers/v1/types.ts | Updated Document type to include an optional javascriptReturns field |
Comments suppressed due to low confidence (1)
apps/api/src/scraper/scrapeURL/engines/fire-engine/index.ts:277
- Consider adding error handling around JSON.parse to avoid potential runtime exceptions if the input string is not valid JSON.
javascriptReturns: (response.actionResults ?? []).filter(x => x.type === "executeJavascript").map(x => JSON.parse((x.result as any as { return: string }).return)),
mogery
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.