Skip to content

fix(v1/checkCredits): snap crawl limit to remaining credits if over without erroring out (FIR-1450)#1350

Merged
mogery merged 1 commit intomainfrom
mog/snap-limit-to-remaining-credits
Mar 16, 2025
Merged

fix(v1/checkCredits): snap crawl limit to remaining credits if over without erroring out (FIR-1450)#1350
mogery merged 1 commit intomainfrom
mog/snap-limit-to-remaining-credits

Conversation

@mogery
Copy link
Member

@mogery mogery commented Mar 16, 2025

this causes a lot of customer confusion, better to just minmax it quietly

@mogery mogery requested a review from nickscamara as a code owner March 16, 2025 15:33
@mogery mogery changed the title fix(v1/checkCredits): snap crawl limit to remaining credits if over without erroring out fix(v1/checkCredits): snap crawl limit to remaining credits if over without erroring out (FIR-1450) Mar 16, 2025
@nickscamara
Copy link
Member

Wouldn't they assume it is broken now in cases where we return way lower than the limit? Could we possibly add a warning that goes with it?

Copy link
Member Author

mogery commented Mar 16, 2025

crawl has no warning field — we'll see in support if it happens

@mogery mogery merged commit 670ca84 into main Mar 16, 2025
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants