fix(map): do not remove query parameters from results (FIR-1015)#1191
Merged
nickscamara merged 2 commits intomainfrom Feb 17, 2025
Merged
fix(map): do not remove query parameters from results (FIR-1015)#1191nickscamara merged 2 commits intomainfrom
nickscamara merged 2 commits intomainfrom
Conversation
mogery
force-pushed
the
mog/fix-map-query-param-handling
branch
6 times, most recently
from
3882dff to
dd8cd63
Compare
mogery
force-pushed
the
mog/fix-map-query-param-handling
branch
from
dd8cd63 to
ba2fe23
Compare
Member
Author
|
NOTE: test failing is unrelated (f-e error), reported issue to Thomas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
sitemapOnly's faithfulness to the real sitemap, and also should improve Extract for sites that use URLs likehttps://example.com/product?id=<xyz>for product pages/anything that needs to be multi-entity extracted.