Update self-hosted Kubernetes deployments examples for compatibility and consistency#1177
Merged
mogery merged 6 commits intofirecrawl:mainfrom Feb 18, 2025
Merged
Update self-hosted Kubernetes deployments examples for compatibility and consistency#1177mogery merged 6 commits intofirecrawl:mainfrom
mogery merged 6 commits intofirecrawl:mainfrom
Conversation
- This commit adds double quotes around variables in the docker-entrypoint.sh script to prevent word splitting and globbing issues, ensuring the script behaves correctly in all cases.
1fbaa92 to
b748382
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Kubernetes deployment configurations (api.yaml, worker.yaml, playwright-service.yaml, configmap.yaml, and README.md) to address compatibility issues and improve consistency with the current Firecrawl application.
Key changes include:
These updates ensure the Kubernetes deployments are correctly configured and function as expected in various environments.