Skip to content

Fix corepack and self hosting setup#1131

Merged
mogery merged 7 commits intofirecrawl:mainfrom
rothnic:fix-corepack
Feb 5, 2025
Merged

Fix corepack and self hosting setup#1131
mogery merged 7 commits intofirecrawl:mainfrom
rothnic:fix-corepack

Conversation

@rothnic
Copy link
Contributor

@rothnic rothnic commented Feb 4, 2025

This is a set of changes that addressed the corepack issue and some additional issues with running the docker compose file in my self-hosted environment.

See issue: #1126

I fixed the corepack issue by following this approach:

After fixing the corepack issue, I was left with this error:

  • ulimit: open files: cannot modify limit: Operation not permitted
  • In my research, you cannot set the ulimit from the docker entrypoint script.
  • You need to set it as part of running the image like docker run --ulimit nofile=65535:65535 your-image or in the docker compose file as i have implemented

@mogery mogery self-assigned this Feb 4, 2025
rothnic and others added 2 commits February 4, 2025 12:22
This implements the proposed approach to not fail when the ulimit command can't run due to the environment
Resolves issue encountered when using docker compose up on a clean environment on an intel mac. This just adds the clean command to avoid leveraging any cached data before updating apt-get and installing ca-certificates
@rothnic
Copy link
Contributor Author

rothnic commented Feb 4, 2025

@mogery I updated the docker-entrypoint.sh file as requested and it worked fine on my server. However, I then tried to clone the branch fresh on my local macbook pro (intel) to test that and ran into a signature issue with one of the commands in the Dockerfile. So, I made a tweak to it to avoid that issue and it works now on my macbook pro as well without having to modify the docker compose or dockerfile.

This I think is now ready to go

Copy link
Member

@mogery mogery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mogery mogery merged commit aa1e820 into firecrawl:main Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants