Fix bad WebSocket URL in CrawlWatcher#1053
Merged
mogery merged 2 commits intofirecrawl:mainfrom Jan 28, 2025
Merged
Conversation
Fixed CrawlWatcher creating WebSocket using standard http url from base app.
Contributor
Author
|
Could improve this by using a regex to replace either |
timoa
pushed a commit
to timoa/firecrawl
that referenced
this pull request
Feb 2, 2025
* fix: bad websocket url in crawl watcher Fixed CrawlWatcher creating WebSocket using standard http url from base app. * Use regex to improve url replacement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed CrawlWatcher creating WebSocket using standard http url from base app.