browsingData.removeCache: removalOptions is not optional #36812
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebExt
rebloor
approved these changes
Nov 27, 2024
|
Preview URLs (comment last updated: 2024-11-27 22:32:09) |
|
@atjn many thanks for spotting that one and making the appropriate changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current text says you can omit the
removalOptionsobject. This is not the case, both Firefox and Chrome will throw an error if you do not pass an empty object to the function. I have changed the text to make this clear.Motivation
It is false information that lead me to write failing code.
Additional details
I unfortunately cannot find any documentation on these APIs, but I have manually tested that this is the case in Firefox 132 and Chrome 130.
The example in this text also passes an empty object.
Related issues and pull requests
Slightly related: #27629