Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conditionnal check - xml not properly formatted #41

Open
GoogleCodeExporter opened this issue Dec 7, 2015 · 6 comments
Open

conditionnal check - xml not properly formatted #41

GoogleCodeExporter opened this issue Dec 7, 2015 · 6 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Add a "and" locgical check 
2. Add a "not" logical check in it
3. A wrong </condition> balise appears

Here is the package produced by wpkgexpress r12

    <package id="polices" name="polices" revision="2" priority="5"
reboot="false">
        <check type="logical" condition="and">
            <check type="file" condition="exists"
path="%WINDIR%\Fonts\STIXNonUniBolIta.otf" />
            <check type="file" condition="exists"
path="%WINDIR%\Fonts\LinLibertine_BI-4.0.5.ttf" />
            <check type="logical" condition="not">
                <check type="file" condition="exists"
path="%windir%\fonts\cmsy10.ttf" />

            </condition>
        </check>
        <install cmd='%COMSPEC% /c copy /Y "%SOFTWARE%\polices\*.*"
"%WINDIR%\Fonts\" ' timeout="300" />
        <install cmd="%comspec% /c del  /Q /S /F %windir%\fonts\cmex10.ttf
%windir%\fonts\cmmi10.ttf %windir%\fonts\cmr10.ttf
%windir%\fonts\cmsy10.ttf" timeout="60" />
        <upgrade cmd='%COMSPEC% /c copy /Y "%SOFTWARE%\polices\*.*"
"%WINDIR%\Fonts\" ' timeout="300" />
        <upgrade cmd="%comspec% /c del /Q /S /F %windir%\fonts\cmex10.ttf
%windir%\fonts\cmmi10.ttf %windir%\fonts\cmr10.ttf
%windir%\fonts\cmsy10.ttf" timeout="60" />
    </package>


Checks are well formatted in the UI, but xml is false

Original issue reported on code.google.com by [email protected] on 6 Feb 2010 at 1:59

Attachments:

@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 26 Feb 2010 at 3:05

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

This patch fixes the problem of the superfluous </conditional> tag (for me, at 
least).

Original comment by [email protected] on 15 May 2010 at 12:40

@GoogleCodeExporter
Copy link
Author

The patch is OK for me too ...

I suggest you do the same in wpkgexpress/views/packages/xml/view.ctp

Thks a lot !

Original comment by [email protected] on 15 May 2010 at 8:01

@GoogleCodeExporter
Copy link
Author

Stupid question: how does one access the xml view template?  I'd rather not 
push out a 
patch until I can make sure it works :)

Original comment by [email protected] on 17 May 2010 at 5:26

@GoogleCodeExporter
Copy link
Author

how does one access the xml view template? 

When you're in a package page, 
 https://webserver/wpkgexpress/packages/view/61

You can see the package by appending .xml 
 https://webserver/wpkgexpress/packages/view/61.xml

But i don't know if it's use somewhere else ...

Your patch is a workaround, but it does work for me too

Original comment by [email protected] on 18 May 2010 at 5:32

@GoogleCodeExporter
Copy link
Author

Thanks for the tip!  Here's an updated version of the patch:

Original comment by [email protected] on 18 May 2010 at 5:45

Attachments:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant