Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make package compatible with Composer 2.0 #1

Open
wget opened this issue Jan 29, 2021 · 5 comments
Open

Make package compatible with Composer 2.0 #1

wget opened this issue Jan 29, 2021 · 5 comments

Comments

@wget
Copy link

wget commented Jan 29, 2021

According to composer/composer#8913 and composer/composer#8726, adding Composer 2.0 support is not that hard and should only require changing this line from:

        "composer-plugin-api": "^1.0"

to:

        "composer-plugin-api": "^1.0 |  ^2.0"

Is this possible for you to bump dependencies to allow that Composer 2.0 compatibility? Thanks :)

@RCheesley
Copy link
Member

Hi there, for info we cannot support Composer 2 with Mautic until Mautic 4 (May 2021).

This is because it requires us to bump some of our dependencies which will be breaking changes that will come in with the work we are doing to support Symfony 4.

If you would like to help with that, here is the WIP PR and you can join #mautic-4 on Slack.

We also have an initiative underway to provide Composer Support in core.

@wget
Copy link
Author

wget commented Jan 29, 2021

That's true you're taking into account the project as a whole. :)

My use case is that my mautic install has been installed using Ansible and plugins are being installed using composer 2.0. Weird use case I have, I know.

So maybe right now, I think we are gonna get back to Composer 1.5 then as this would make things easier to manage. :)

Thanks for the link you provided, I'll check them :)

@jonathonbyrdziak
Copy link

Now that Mautic 4 is out, are you able to support composer 2?

@rjocoleman
Copy link

I've added support for Composer 2 in #2 (but I'm a first time contributor to Mautic so unsure how things go from here)

@RCheesley
Copy link
Member

Thanks @rjocoleman I've asked the core team and also our Composer Initiative lead to review the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants