Scroll on new lines #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addition will make sure that the document scrolls properly when inserting a new line. You might want to make it optional and have a setting for it. I am using this by modifying the installed extension code directly, and it works like a charm, but it's not tested properly as I haven't tried compiling the ts files.
|
Sweet, I like it :-) Thanks for the PR |
|
Thanks! Although I just thought of a case where it would break. If you're not on the last line (for example after a go-to) then newlines will make it scroll to the end. Should probably reveal the current line (the one where the cursor is after inserting the new line) instead of the last line. |
|
This change should fix that issue #12 |
|
Great! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition will make sure that the document scrolls properly when inserting a new line. You might want to make it optional and have a setting for it. I am using this by modifying the installed extension code directly, and it works like a charm, but it's not tested properly as I haven't tried compiling the ts files.