Adding anaconda dev container #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I'll take a look |
|
I have made a second commit to make awake_sleep_seconds optional and support None - I created a new issue #31 to link to this. |
matin
reviewed
Nov 2, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 34 34
Lines 1240 1240
=========================================
Hits 1240 1240
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
@nzigel are you running the pre-commit hooks? Lint is failing |
Adding dev container to VSCode to enable local execution.
I have some days in my Garmin Sleep data where I have no restless moments sleeping this results in an error daily_sleep_dto.awake_sleep_seconds Input should be a valid integer [type=int_type, input_value=None, input_type=NoneType]
Removing the unnecessary comments from the devcontainer.json and docker files.
I had a strange sleep report when crossing timezones flying back from Europe where the sleep score was INVALID and values were missing. Making the missing values optional to remove validation errors.
|
Just rebasing and running checks again. When they pass, I'll merge and release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
awake_sleep_secondsoptional. Closes Make awake_sleep_seconds optional and support None #31