Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check_boxes label should use display: inline-block #9348

Merged
merged 1 commit into from
Nov 25, 2018
Merged

check_boxes label should use display: inline-block #9348

merged 1 commit into from
Nov 25, 2018

Conversation

takayamaki
Copy link
Contributor

Check boxes labels of chosen language in /settings/preferences are too wide.
It cause accidentally click.
Users said to me about this, "Public timeline does not work."

2018-11-25 23-23-21

before after
2018-11-25-232203_1920x983_scrot 2018-11-25-232133_1920x983_scrot

@takayamaki takayamaki mentioned this pull request Nov 25, 2018
Closed
2 tasks
@Gargron Gargron merged commit 180ae04 into mastodon:master Nov 25, 2018
@fvh-P
Copy link
Contributor

fvh-P commented Nov 25, 2018

This modification is not bad, however, first of all, it should stop putting a lot of check boxes.
Now the LANGUAGES preference is taking up a lot of space in the preferences page...

@takayamaki takayamaki deleted the fix-simple-form-checkboxes-label-style branch November 25, 2018 16:05
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
@takayamaki @hiyuki2578
check_boxes label should use display: inline-block (mastodon#9348)
2389f03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayaeh mayaeh mayaeh approved these changes

@Gargron Gargron Gargron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@takayamaki @fvh-P @Gargron @mayaeh