Sort self-replies to the top of descendants #9320
Conversation
| def promote_by!(arr, &condition) | ||
| insert_at = arr.find_index { |item| !condition.call(item) } | ||
|
|
||
| return arr if insert_at.nil? |
There was a problem hiding this comment.
This will always be the first status, right, since it isn't a reply?
There was a problem hiding this comment.
Descendants does not contain the status being replied to originally, as far as I remember. So these are all replies. However, if it's all self-replies, then there is nothing to do here, therefore return array.
|
What happens with the following thread (where “a → b” denotes that b replied to a)? I'm afraid this gives |
Gargron
changed the title
Gargron
added
api
Gargron
force-pushed
the
fix-thread-ordering
branch
from
ef4b101 to
82ebdd3
Compare
|
@ThibG That shouldn't happen, because in_reply_to_account_id carries over between self-replies. So if I reply to Bob, then reply to my reply to Bob, in_reply_to_account_id is Bob, not me. |
|
@Gargron ok, I didn't know that, that's super confusing. This PR should be fine in that regard, then. I'm pretty sure my inline comment still stands, though, but that's a performance issue, not a functional one. |
Fix #6463