Fix language selector on preferences page #2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, good catch and good change. Is adding a blank option here to allow users to leave nothing selected better ... or is default to their i18n'd language (like your change) better? I guess if they are on a server where the default is ok for them, it's basically the same either way, and doesn't matter if it's saved as their locale or just that they are getting it set anyway. |
mjankowski
approved these changes
May 4, 2017
ClearlyClaire
added a commit
to ClearlyClaire/mastodon
that referenced
this pull request
Jul 25, 2024
…upstream Merge upstream changes up to e507d17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user's language is detected automatically.
But the language isn't set in the language selector by default.
So when non-English users change other settings on the Preferences page (e.g. Post privacy)
and save changes, the language setting is changed to English unintentionally.
This commit fixes this issue by set detected language to the selector by default.
And maybe fix #1558.