Remove unused methods in 2FA OTP Auth Controller #24220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjankowski
force-pushed
the
remove-unused-otp-auth-methods
branch
2 times, most recently
from
21ab4f0 to
7c0c363
Compare
mastodon@e8d41bc In a previous refactor the approach here was changed to not do this logic until the next confirmation step, but the methods were left behind.
mjankowski
force-pushed
the
remove-unused-otp-auth-methods
branch
from
7c0c363 to
2f1da69
Compare
ClearlyClaire
approved these changes
Apr 7, 2023
ClearlyClaire
added a commit
to glitch-soc/mastodon
that referenced
this pull request
Apr 9, 2023
* Bump addressable from 2.8.1 to 2.8.2 (mastodon#24392) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump typescript from 4.9.5 to 5.0.3 (mastodon#24398) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add typechecking in CI (mastodon#24405) * HTML string attributes set as booleans (mastodon#24408) * Ensure tabIndex is number instead of string (mastodon#24409) * Fix styling regressions from RTL layout refactor (mastodon#24415) * Enable Stylelint property-no-unknown (mastodon#24404) * SUBMIT doesn't exist on XMLHttpRequest (mastodon#24423) * Set marginRight as string (mastodon#24422) * Update display_media typing to string (mastodon#24416) * Bump aws-sdk-s3 from 1.119.2 to 1.120.0 (mastodon#24401) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump capybara from 3.38.0 to 3.39.0 (mastodon#24395) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump puma from 6.1.1 to 6.2.1 (mastodon#24402) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump rubocop from 1.48.1 to 1.49.0 (mastodon#24387) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix height of announcements not being updated when using reduced animations (mastodon#24354) * Check for missing JSON translations (mastodon#24338) * Fix user archive takeouts when using OpenStack Swift (mastodon#24431) * Fix DevContainer post-create warnings (mastodon#23977) * New Crowdin updates (mastodon#24378) Co-authored-by: Yamagishi Kazutoshi <[email protected]> * Bump version to v4.1.2 (mastodon#24427) * Fix user settings migration script failing in some cases (mastodon#24453) * Fix account header image missing in low-res (mastodon#24433) * Remove Array.prototype.includes polyfill (mastodon#24234) * Remove duplicate ca-certificates Docker install (mastodon#24231) * Remove unused methods in 2FA OTP Auth Controller (mastodon#24220) * Update Node.js to 16.20.0 (mastodon#24316) * Expand coverage for "system checks" (mastodon#24216) * Fix loading spinner + infinite scroll for private mentions (mastodon#24446) * Fix tooltip for dates without time (mastodon#24244) * Fix crash in NotifyService when trying to send an email notification for post edits (mastodon#24460) * [Glitch] HTML string attributes set as booleans Port a425915 to glitch-soc Signed-off-by: Claire <[email protected]> * [Glitch] SUBMIT doesn't exist on XMLHttpRequest Port ab3f23d to glitch-soc Signed-off-by: Claire <[email protected]> * [Glitch] Set marginRight as string Port 927b2fd to glitch-soc Signed-off-by: Claire <[email protected]> * [Glitch] Update display_media typing to string Port 17b2fd2 to glitch-soc Signed-off-by: Claire <[email protected]> * [Glitch] Fix height of announcements not being updated when using reduced animations Port ffd5b2e to glitch-soc Signed-off-by: Claire <[email protected]> * [Glitch] Fix account header image missing in low-res Port d7b8c6d to glitch-soc Signed-off-by: Claire <[email protected]> * [Glitch] Remove Array.prototype.includes polyfill Port c0886de to glitch-soc Signed-off-by: Claire <[email protected]> * [Glitch] Fix tooltip for dates without time Port aa136cf to glitch-soc Signed-off-by: Claire <[email protected]> * [Glitch] Enable Stylelint property-no-unknown Port cd14f71 to glitch-soc Signed-off-by: Claire <[email protected]> * [Glitch] Fix loading spinner + infinite scroll for private mentions Port 9ef9974 to glitch-soc Signed-off-by: Claire <[email protected]> * [Glitch] Ensure tabIndex is number instead of string Port ec0c104 to glitch-soc Signed-off-by: Claire <[email protected]> * [Glitch] Fix user settings migration script failing in some cases * Move glitch-soc-only translation strings out of `app/javascript/mastodono/locales` * Run `yarn manage:translations` --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Claire <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nick Schonning <[email protected]> Co-authored-by: Christian Schmidt <[email protected]> Co-authored-by: Eugen Rochko <[email protected]> Co-authored-by: Yamagishi Kazutoshi <[email protected]> Co-authored-by: Matt Jankowski <[email protected]>
skerit
pushed a commit
to 11ways/mastodon
that referenced
this pull request
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous refactor - e8d41bc - the approach here was changed to not do this logic until the next confirmation step, but the methods were left behind.