-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/272 es6 pkg module #275
Feature/272 es6 pkg module #275
Conversation
It's failing due to webpack version. As a side note, later, we should replace webpack by rollup |
I wonder if just rolling back |
…n the Webpack side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a fan and I love seeing work being done to keep the package up-to-date with the latest build tools.
I just have a question around artefacts as I'm a bit behind on how es6 package modules work.
@@ -4,6 +4,7 @@ | |||
"homepage": "https://github.com/marionettejs/backbone.radio", | |||
"version": "2.0.0", | |||
"main": "build/backbone.radio.js", | |||
"module": "build/backbone.radio.esm.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this file need to be checked into the source tree or is it automatically generated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes, I should have added the module and source map to git
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's wired into the build so would get generated with the rest of the files in build/
in the future.
I'm not sure what needs to be done, if anything for the NPM package to include the ES modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The es build must be in the package distributed.
Commit in the repository is optional. Anyway if deciding to commit to repository, It should be done only just before a release.
gulpfile.babel.js
Outdated
function build(done) { | ||
rollup.rollup({ | ||
var banner = getBanner(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line doesn't appear to be in use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, detritus. Yanked in 8f563e5
@marionettejs/marionette-core if 2nd thumb'd squash and merge |
We need to make sure this has named exports |
I think it can be merged as is. The addition of named exports can be added later since means a bigger change and needs some discussion. Radio public API is basically While in Marionette migrating everything to named exports and killing the default exports was straight, in Radio doing the same will be a big breaking change. By far the most used API in
By migrating to named exports like it would need to be changed to
There's some issues:
So migrating to named exports is possible but will need some API design changes that at this time (just before releasing marionette v4) i don't think is doable. I propose to merge this and open a new issue for named export |
Fixes #272