fix: mo.ui.altair_chart when give by the user #2924
Merged
+827
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
akshayka
reviewed
Nov 22, 2024
| if _has_selection_param(chart): | ||
| # Log a warning if the user has set chart_selection | ||
| # but the chart already has a selection param | ||
| print("chart_selection", chart_selection) |
There was a problem hiding this comment.
Suggested change
| print("chart_selection", chart_selection) |
| if _has_legend_param(chart): | ||
| # Log a warning if the user has set legend_selection | ||
| # but the chart already has a legend param | ||
| print("legend_selection", legend_selection) |
There was a problem hiding this comment.
Suggested change
| print("legend_selection", legend_selection) |
akshayka
previously approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2901
If selection params are already added by the users, we should not automatically the default chart/legend selection and just use the users.